Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove the mutating and validating webhooks for v1alpha2 Subscription #549

Merged
merged 27 commits into from
Apr 18, 2024
Merged

feat: remove the mutating and validating webhooks for v1alpha2 Subscription #549

merged 27 commits into from
Apr 18, 2024

Conversation

marcobebway
Copy link
Contributor

@marcobebway marcobebway commented Apr 11, 2024 •
edited
Loading

Description

Remove the mutating and validating webhooks for v1alpha2 Subscription.

⚠️ Hints for reviewers ⚠️

  • The documentation changes will be done in a follow-up PR.

Related issue(s)

@marcobebway marcobebway requested review from a team as code owners April 11, 2024 14:37
@marcobebway marcobebway requested a review from k15r April 11, 2024 14:37
@kyma-bot kyma-bot added area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. labels Apr 11, 2024
@marcobebway marcobebway linked an issue Apr 11, 2024 that may be closed by this pull request
Replace defaulting/validation webhooks of v1alpha2 Subscription API with CEL #443
Closed
7 tasks
@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 11, 2024
@marcobebway marcobebway added the area/eventing Issues or PRs related to eventing label Apr 11, 2024
@marcobebway
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/ci Issues or PRs related to CI related topics labels Apr 11, 2024
@marcobebway marcobebway force-pushed the 443-remove-subscription-v1alpha2-webhooks branch 6 times, most recently from cc2a0a9 to 1562614 Compare April 15, 2024 12:39
@marcobebway marcobebway requested review from mfaizanse and removed request for a team and k15r April 16, 2024 09:59
mfaizanse
mfaizanse reviewed Apr 17, 2024
View reviewed changes
api/eventing/v1alpha2/condition.go Show resolved Hide resolved
api/eventing/v1alpha2/condition.go Show resolved Hide resolved
config/rbac/role.yaml Outdated Show resolved Hide resolved
internal/controller/eventing/subscription/eventmesh/reconciler.go Outdated Show resolved Hide resolved
internal/controller/eventing/subscription/validator/spec.go Show resolved Hide resolved
internal/webhook/cleanup.go Outdated Show resolved Hide resolved
mfaizanse
mfaizanse previously approved these changes Apr 17, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 17, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 17, 2024
@marcobebway marcobebway force-pushed the 443-remove-subscription-v1alpha2-webhooks branch 2 times, most recently from 394fb60 to 1b0ca3f Compare April 17, 2024 11:38
@marcobebway marcobebway requested a review from mfaizanse April 17, 2024 11:39
mfaizanse
mfaizanse previously approved these changes Apr 17, 2024
View reviewed changes
@marcobebway
Refactor subscription validation
cc8593b
@marcobebway
Refactoring
ceef046
@marcobebway
Add subscription validation tests
a28c332
@marcobebway
Test subscription validation in the reconciler using mocks
c9882e8
@marcobebway
Fix lint issues
559fc92
@marcobebway
Refactoring
6d5063c
@marcobebway
Refactor type matching validation
46f4890
@marcobebway
Refactoring validation
618c360
@marcobebway
Undo doc changes
85ff6ae
@marcobebway
Update validation tests
788e374
@marcobebway
Add defaulting tests
b6c2bde
@marcobebway
Remove not needed setup
d4fc940
@marcobebway
Update defaulting expr
fef264d
@marcobebway
Fix lint issues
de5395f
@marcobebway
Add tests for webhook resources cleanup
7b3799a
@marcobebway
Add tests for subscription spec valid conditions
4491b69
@marcobebway
Restrict delete job and cronjobs only to the target resources
f7a5a0d
@marcobebway
Fix lint issues
c0b96ba
@marcobebway
Preserve the old subscription status in case of the EventMesh backend
13ee8be
@marcobebway
Fix generated config
ed204a6
@marcobebway
Remove webhook cleanup logic
cb0c887
@marcobebway marcobebway force-pushed the 443-remove-subscription-v1alpha2-webhooks branch from 1b0ca3f to cb0c887 Compare April 18, 2024 13:02
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 18, 2024
@marcobebway
Copy link
Contributor Author

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@kyma-bot kyma-bot merged commit f71e3c4 into kyma-project:main Apr 18, 2024
17 checks passed
@marcobebway marcobebway deleted the 443-remove-subscription-v1alpha2-webhooks branch April 18, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaizanse mfaizanse mfaizanse approved these changes

Assignees

@mfaizanse mfaizanse

Labels
area/ci Issues or PRs related to CI related topics area/documentation Issues or PRs related to documentation area/eventing Issues or PRs related to eventing cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace defaulting/validation webhooks of v1alpha2 Subscription API with CEL
3 participants
@marcobebway @mfaizanse @kyma-bot