Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unify CR description in Kyma dashboard #573

Closed
wants to merge 5 commits into from
Closed

fix: unify CR description in Kyma dashboard #573

wants to merge 5 commits into from

Conversation

mmitoraj
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Unify Eventing CR's description and the link to the Eventing documentation to be consistent with all CR descriptions in Kyma dashboard

Related issue(s)
kyma-project/kyma#18321

@mmitoraj mmitoraj requested a review from a team as a code owner May 21, 2024 09:07
@mmitoraj mmitoraj requested a review from marcobebway May 21, 2024 09:07
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2024
@mmitoraj mmitoraj changed the title Unify CR description in Kyma dashboard fix: Unify CR description in Kyma dashboard May 21, 2024
@k15r k15r changed the title fix: Unify CR description in Kyma dashboard fix: unify CR description in Kyma dashboard May 21, 2024
k15r
k15r previously approved these changes May 21, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 21, 2024
@mmitoraj mmitoraj removed the request for review from marcobebway May 22, 2024 10:49
@mmitoraj
Copy link
Contributor Author

/retest

@mfaizanse
Copy link
Member

Lets wait for PR: #572

@mfaizanse mfaizanse added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 23, 2024
@mfaizanse
Copy link
Member

@mmitoraj Can you merge latest changes from main to your PR?

@kyma-bot
Copy link

New changes are detected. LGTM label has been removed.

@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2024
@mmitoraj
Copy link
Contributor Author

@mmitoraj Can you merge latest changes from main to your PR?

@mfaizanse Hi, I think I successfully rebased, could you have a look and approve if everything is ok?

@mfaizanse mfaizanse changed the base branch from main to release-1.2 May 28, 2024 07:48
@mfaizanse mfaizanse requested a review from a team as a code owner May 28, 2024 07:48
@mfaizanse mfaizanse changed the base branch from release-1.2 to main May 28, 2024 07:48
@mmitoraj mmitoraj closed this May 28, 2024
@mmitoraj mmitoraj deleted the cr-descr branch May 28, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k15r k15r k15r left review comments

Assignees

@k15r k15r

Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmitoraj @mfaizanse @kyma-bot @k15r @halamix2