Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change NATS CR wait for Warning status #576

Merged
merged 1 commit into from
May 24, 2024

Conversation

mfaizanse
Copy link
Member

Description

Changes proposed in this pull request:

  • Change NATS CR wait for Warning status in backend-switching job, because in the latest version of nats-manager the CR will be in Warning state when the k8s is spread across less than 3 availability zones.

Related issue(s)

@mfaizanse mfaizanse requested a review from a team as a code owner May 23, 2024 15:05
@mfaizanse mfaizanse requested a review from k15r May 23, 2024 15:05
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 24, 2024
@mfaizanse mfaizanse merged commit 7f34a15 into kyma-project:main May 24, 2024
14 of 16 checks passed
@mfaizanse mfaizanse deleted the fix-nats-wait branch May 24, 2024 09:10
mmitoraj pushed a commit to mmitoraj/eventing-manager that referenced this pull request May 27, 2024
the1bit pushed a commit that referenced this pull request Sep 3, 2024
kyma-bot pushed a commit that referenced this pull request Sep 4, 2024
* auto-bump sec-scanners-config: 2024-04-23-11-55-04 (#562)

Co-authored-by: kyma-eventing-bot <kyma-eventing-bot"@users.noreply.github.com>

* docs: improve the troubleshooting guide for Eventing (#569)

* docs: Improve the trouble shooting guide

* Apply suggestions from code review

Co-authored-by: Nina Hingerl <[email protected]>

---------

Co-authored-by: Nina Hingerl <[email protected]>

* chore: deprecate kyma provision gardener (#572)

* Deprecate kyma provision gardener

* remove unused env

* Fix typo in Gardener provisioning (#574)

* fix: Gardener kubeconfig merging flags (#575)

* fix: change NATS CR wait for Warning status (#576)

* fix: unify CR description in Kyma dashboard (#578)

* Added github action for K8s version compatibility check (#583)

* fixed k8s compatibility check job to use provided k8s version (#584)

* fixed gardener provisioning make target to use correct env (#585)

* deps(dependabot): bump golangci/golangci-lint-action from 4.0.0 to 6.0.1 (#568)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 4.0.0 to 6.0.1.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v4.0.0...v6.0.1)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: bump dependencies (#590)

* Upgrade modules for DependaBot PRs (#596)

* deps(dependabot): bump github.com/onsi/gomega from 1.33.1 to 1.34.0 (#600)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.33.1 to 1.34.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.33.1...v1.34.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Change enable and disable to add and delete in the eventing repo (#601)

* chore: fix k8s compatibility test (#599)

* deps(dependabot): bump github.com/vektra/mockery/v2 (#603)

Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.43.2 to 2.44.1.
- [Release notes](https://github.com/vektra/mockery/releases)
- [Changelog](https://github.com/vektra/mockery/blob/master/docs/changelog.md)
- [Commits](vektra/mockery@v2.43.2...v2.44.1)

---
updated-dependencies:
- dependency-name: github.com/vektra/mockery/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps(dependabot): bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 (#605)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.0.1 to 6.1.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v6.0.1...v6.1.0)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps: update build image (#606)

* update some dependencies

* bump docker image

* fix docker registery address

* use older image

* bump go version (#608)

* Update link to default CR for NATS (#615)

Currently the link for the default CR which uses `NATS` backend is pointing to the one that has no backend. This PR fixes this.

* deps(dependabot): bump github.com/prometheus/client_golang (#617)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.19.1 to 1.20.1.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.1/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.19.1...v1.20.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* deps(dependabot): bump github.com/vektra/mockery/v2 (#618)

Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.44.1 to 2.45.0.
- [Release notes](https://github.com/vektra/mockery/releases)
- [Changelog](https://github.com/vektra/mockery/blob/master/docs/changelog.md)
- [Commits](vektra/mockery@v2.44.1...v2.45.0)

---
updated-dependencies:
- dependency-name: github.com/vektra/mockery/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: bump dependencies (#614)

* chore: bump dependencies

* updated

* fixed test

* Fix backend switching

* Fix script

* Increase wait timeout for modules to be ready

---------

Co-authored-by: marcobebway <[email protected]>

* Update CONTRIBUTING.md (#626)

* Bump EPP new version

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Kyma Eventing Bot <[email protected]>
Co-authored-by: kyma-eventing-bot <kyma-eventing-bot"@users.noreply.github.com>
Co-authored-by: Rakesh Garimella <[email protected]>
Co-authored-by: Nina Hingerl <[email protected]>
Co-authored-by: Piotr Halama <[email protected]>
Co-authored-by: Piotr Halama <[email protected]>
Co-authored-by: Muhammad Faizan <[email protected]>
Co-authored-by: Małgorzata Świeca <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mansur Uralov <[email protected]>
Co-authored-by: Grzegorz Karaluch <[email protected]>
Co-authored-by: Marco Bebway <[email protected]>
Co-authored-by: Friedrich <[email protected]>
Co-authored-by: Carina Kothe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants