Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed gardener provisioning make target to use correct env #585

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: fixed gardener provisioning make target to use correct env #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hack/ci/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ KYMA_CLI ?= "${PROJECT_ROOT}/${KYMA}"
CLUSTER_NAME ?= kyma
REGISTRY_PORT ?= 5001
K3D_VERSION ?= 1.28.4
GARDENER_KUBE_VERSION ?= 1.28.4
GARDENER_CLUSTER_VERSION ?= 1.28.4

.PHONY: create-kyma-system-ns
create-kyma-system-ns: ## Create kyma-system namespace.
Expand Down Expand Up @@ -80,7 +80,7 @@ wait-api-gateway-cr-ready:

.PHONY: provision-gardener-cluster
provision-gardener-cluster:
GARDENER_CLUSTER_VERSION="${GARDENER_KUBE_VERSION}" PROJECT_ROOT="${PROJECT_ROOT}" ${PROJECT_ROOT}/scripts/gardener/aws/provision.sh
GARDENER_CLUSTER_VERSION="${GARDENER_CLUSTER_VERSION}" PROJECT_ROOT="${PROJECT_ROOT}" ${PROJECT_ROOT}/scripts/gardener/aws/provision.sh

.PHONY: deprovision-gardener-cluster
deprovision-gardener-cluster:
Expand Down
2 changes: 1 addition & 1 deletion scripts/gardener/aws/provision.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ gardener::validate_and_default() {
utils::check_required_vars "${requiredVars[@]}"

# validations
if [ "${#CLUSTER_NAME}" -gt 9 ]; then
if [ "${CLUSTER_NAME}" -gt 9 ]; then
log::error "Provided cluster name is too long"
return 1
fi
Expand Down
Loading