Fix minor issues

pkg/application/lister.go

@@ -18,7 +18,7 @@ import (
 	emlogger "github.com/kyma-project/eventing-manager/pkg/logger"
 )
 
-var ErrFailedToConvertObjectToUnstructured = errors.New("failed to convert runtime object to unstructured") // Static error.
+var ErrFailedToConvertObjectToUnstructured = errors.New("failed to convert runtime object to unstructured")
 
 type Lister struct {
 	lister cache.GenericLister

pkg/cloudevents/builder/generic.go

@@ -12,7 +12,7 @@ import (
 	"github.com/kyma-project/eventing-manager/pkg/logger"
 )
 
-var ErrEventTypeCannotHaveEmptySegments = fmt.Errorf("event type cannot have empty segments after cleaning") // Static error.
+var ErrEventTypeCannotHaveEmptySegments = fmt.Errorf("event type cannot have empty segments after cleaning")
 
 // Perform a compile-time check.
 var _ CloudEventBuilder = &GenericBuilder{}
@@ -59,7 +59,7 @@ func (gb *GenericBuilder) Build(event ceevent.Event) (*ceevent.Event, error) {
 	// validate if the segments are not empty
 	segments := strings.Split(finalEventType, ".")
 	if DoesEmptySegmentsExist(segments) {
-		return nil, fmt.Errorf("ErrEventTypeCannotHaveEmptySegments %w: %s", ErrEventTypeCannotHaveEmptySegments, finalEventType)
+		return nil, fmt.Errorf("%w: %s", ErrEventTypeCannotHaveEmptySegments, finalEventType)
 	}
 	namedLogger.Debugf("using event type: %s", finalEventType)
 

pkg/handler/handler_v1alpha1_test.go

@@ -34,7 +34,7 @@ import (
 	emlogger "github.com/kyma-project/eventing-manager/pkg/logger"
 )
 
-var ErrUnableToClean = fmt.Errorf("unable to clean") // Static error.
+var ErrUnableToClean = fmt.Errorf("unable to clean")
 
 func Test_extractCloudEventFromRequest(t *testing.T) {
 	type args struct {

pkg/nats/connect.go

@@ -6,7 +6,7 @@ import (
 	"github.com/nats-io/nats.go"
 )
 
-var ErrNATSConnectionNotConnected = fmt.Errorf("NATS connection not connected") // Static error.
+var ErrNATSConnectionNotConnected = fmt.Errorf("NATS connection not connected")
 
 type Opt = nats.Option
 

pkg/signals/signals.go

@@ -9,7 +9,7 @@ import (
 	"time"
 )
 
-var ErrReceivedTerminationSignal = errors.New("received a termination signal") // Static error
+var ErrReceivedTerminationSignal = errors.New("received a termination signal")
 
 //nolint:gochecknoglobals // defining channels
 var (