Release workflow #32
Merged
Release workflow #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
friedrichwilken
requested changes
Jan 3, 2024
Use correct script in `Get the next release version` step Add lines between steps
Move `outputs` at beginning of step for readability
friedrichwilken
requested changes
Jan 4, 2024
Rename steps to be more clear
| run: | | ||
| CURRENT_BRANCH=$(git rev-parse --abbrev-ref HEAD) | ||
| if [[ "$CURRENT_BRANCH" == release-* ]]; then | ||
| echo "current_branch=$CURRENT_BRANCH" >> $GITHUB_ENV |
There was a problem hiding this comment.
Why not simply
Suggested change
| echo "current_branch=$CURRENT_BRANCH" >> $GITHUB_ENV | |
| echo "$CURRENT_BRANCH" >> $GITHUB_ENV |
and use $CURRENT_BRANCH" in the following steps?
There was a problem hiding this comment.
As I understood it, I need a variable name to set an environment variable: https://docs.github.com/en/github-ae@latest/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable
There was a problem hiding this comment.
oh, I understand now.
friedrichwilken
approved these changes
Jan 5, 2024
kyma-bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
* Setup E2E test using NATS Backend (#30) * Setup E2E github action flow * Move hack Makefile * Move ci folder outside of e2e * Correct makefile path * Add missing step to e2e flow to checkout repo * Correct path in Makefile * Add kustomize to Makefile * Add kustomization * Add LOCALBIN variable * Add k3d cluster create step * Remove go step * Add missing variables to Makefile * Add kyma script * Make script executable * Checkout EM repositry * Correct repository checkout * Use EM repo for e2e tests * Remove hack/Makefile * Replace make command with local one * Try adding sudo for `permission denied` problem * Try using `kyma` instead of variable * Try using explicit path * Use different make targets to deploy EM * Update image * Fix reference of variable * Add step to create namespace * Fix Github token * Fix make calls in workflow * Add step to install NATS * Try to use Github variable * Deploy nats manager via makefile * Add step to install NATS CR * Fix reference of variable * Try using `create-k3d` from `eventing-manager` repo * Change KYMA_CLI path * Undo variable changes * Remove unused files * Add clean-up step Fix capitalisation * Improve patch command by using `jq` * Add missing path to cleanup command * Try using `MODULE_VERSION` from EM Repo * Echo Module Version Use rel version for nats manager * Print deployment image * Fix kubectl command * Try to use string * Try using `yg` to extract version * Fix command * Use `grep` instead of `yq` * Use curl to get latest release of NM * Use `curl` to get EM latest release Use `latest` for NM * Use NM image used in release * Use `kubectl apply` to deploy latest NATS and Eventing Manager * Remove step to test EM setup * Remove unused variable * Check for pod rollout * Add missing `$` to variable * Wait for rollout to complete * Add step to check for success of EPP image update * Replace `k` with `kubectl` * Release workflow (#32) * Release workflow * Rename to `sec-scan` * Fix all variables to `eventing-publisher-proxy` * Fix output of next release version * Fix run name to branch name Use correct script in `Get the next release version` step Add lines between steps * Use correct image in `sec-scanners-config` * Use env variable for using job output Move `outputs` at beginning of step for readability * Rename scripts to be more descriptive Rename steps to be more clear * Use script with more comments * Add release flow (#31) * Add release flow * Release using branch name as input * Fix `needs` input * Fix `needs` input * Change workflow to be triggered manually * No inputs for manual trigger * Release workflow * Remove unused scripts
grischperl
added a commit
to grischperl/eventing-publisher-proxy
that referenced
this pull request
Jan 9, 2024
* Release workflow * Rename to `sec-scan` * Fix all variables to `eventing-publisher-proxy` * Fix output of next release version * Fix run name to branch name Use correct script in `Get the next release version` step Add lines between steps * Use correct image in `sec-scanners-config` * Use env variable for using job output Move `outputs` at beginning of step for readability * Rename scripts to be more descriptive Rename steps to be more clear * Use script with more comments
grischperl
added a commit
to grischperl/eventing-publisher-proxy
that referenced
this pull request
Jan 9, 2024
This reverts commit 9afd151.
kyma-bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Add e2e testing documentation * Implement review comments * Implement review comment * Release workflow (#32) * Release workflow * Rename to `sec-scan` * Fix all variables to `eventing-publisher-proxy` * Fix output of next release version * Fix run name to branch name Use correct script in `Get the next release version` step Add lines between steps * Use correct image in `sec-scanners-config` * Use env variable for using job output Move `outputs` at beginning of step for readability * Rename scripts to be more descriptive Rename steps to be more clear * Use script with more comments * Fix referencing of output variable (#35) * Implement review comments * Revert "Release workflow (#32)" This reverts commit 9afd151. * Revert "Fix referencing of output variable (#35)" This reverts commit 18cd0ad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Github Action to create a release.
Changes proposed in this pull request:
release-x.yas input for release versionx.y.zRelated issue(s)
kyma/#18477