Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new name for the Eventing Manager CR #61

Closed
wants to merge 2 commits into from
Closed

Use the new name for the Eventing Manager CR #61

wants to merge 2 commits into from

Conversation

grischperl
Copy link
Contributor

@grischperl grischperl commented Jan 18, 2024 •
edited
Loading

Description

Due to the changes in Eventing Manager the default CR has changed. According to the new setup, the Eventing Manager has an empty backend per default. This means, during testing, the NATS backend needs to be set.

Changes proposed in this pull request:

  • Use the new name: eventing-default-cr
  • Use sample CR with NATS backend configured (not the default CR)

Related issue(s)

@grischperl grischperl requested review from the1bit and a team as code owners January 18, 2024 14:18
@grischperl grischperl requested a review from muralov January 18, 2024 14:18
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2024
@grischperl grischperl changed the title Use the new name for the Eventing Manager manager.yaml Use the new name for the Eventing Manager CR Jan 18, 2024
@NHingerl
Copy link
Contributor

NHingerl commented Jan 22, 2024 •
edited
Loading

Pls remember to update the eventing manager README (section: Install) as well.
Edit: Doesn't have to be in this PR, follow-up PR is fine.

@grischperl grischperl added this to the 1.1.0 milestone Feb 1, 2024
@grischperl
Copy link
Contributor Author

Fixed in: #65

@grischperl grischperl closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the1bit the1bit Awaiting requested review from the1bit the1bit is a code owner

@muralov muralov Awaiting requested review from muralov muralov is a code owner automatically assigned from kyma-project/eventing

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@grischperl @NHingerl @kyma-bot