Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint: goerr113 #71

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Fix lint: goerr113 #71

merged 4 commits into from
Feb 1, 2024

Conversation

the1bit
Copy link
Contributor

@the1bit the1bit commented Jan 31, 2024

Description

Changes proposed in this pull request:

  • Fix lint: goerr113 (Static errors)

Related issue(s)

.golangci.yaml PR: kyma-project/eventing-tools#64

@the1bit the1bit requested a review from a team as a code owner January 31, 2024 13:46
@the1bit the1bit requested a review from muralov January 31, 2024 13:46
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 31, 2024
@the1bit the1bit added area/cli Related to all activities around CLI kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jan 31, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Jan 31, 2024
@marcobebway marcobebway requested review from marcobebway and removed request for muralov February 1, 2024 09:57
marcobebway
marcobebway reviewed Feb 1, 2024
View reviewed changes
pkg/signals/signals.go Outdated Show resolved Hide resolved
@the1bit the1bit requested a review from marcobebway February 1, 2024 11:18
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 1, 2024
@kyma-bot kyma-bot merged commit aec50fa into kyma-project:main Feb 1, 2024
7 checks passed
@the1bit the1bit deleted the Fix-lint-goerr113 branch February 1, 2024 11:32
mfaizanse pushed a commit to mfaizanse/eventing-publisher-proxy that referenced this pull request Sep 3, 2024
@the1bit @mfaizanse
Fix lint: goerr113 (kyma-project#71)
c78dd47 
* Add static errors

* Linter config

* Fix clean message

* Fix minor issues
the1bit added a commit that referenced this pull request Sep 3, 2024
@the1bit
Fix lint: goerr113 (#71)
ee27dba 
* Add static errors

* Linter config

* Fix clean message

* Fix minor issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcobebway marcobebway marcobebway approved these changes

Assignees

@marcobebway marcobebway

Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@the1bit @marcobebway @kyma-bot