Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a reusable linting github action workflow #55

Merged

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Jan 17, 2024

Description

Changes proposed in this pull request:

  • adds a reusable GitHub action workflow, that runs a Go linter base on Golangci-lint

This change will allow us to re-use the same linting workflow between multiple repos and in multiple workflows, e.g., Create release.

This was tested by implementing the same workflow here and then, calling it from this repo, resulted in a successful detection of linting issues in this dummy PR.

Related issue(s)
kyma-project/eventing-manager#361

@friedrichwilken friedrichwilken requested a review from a team as a code owner January 17, 2024 23:30
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2024
@friedrichwilken friedrichwilken linked an issue Jan 17, 2024 that may be closed by this pull request
3 tasks
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 18, 2024
@kyma-bot kyma-bot merged commit 4bf48de into kyma-project:main Jan 18, 2024
5 checks passed
@friedrichwilken friedrichwilken deleted the add-reusbale-linting-job branch January 18, 2024 08:58
@friedrichwilken friedrichwilken self-assigned this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants