Centralized linter #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
area/ci
There was a problem hiding this comment.
Maybe you want to replace the existing one so we do not have this twice.
https://github.com/kyma-project/eventing-tools/blob/main/.github/workflows/lint-reusable.yml
There was a problem hiding this comment.
You could just apply your changes to the existing file instead.
There was a problem hiding this comment.
I want to replace it. The only reason I did not do it, because Eventing Manager uses it. I don't want to kill that solution, until this solution will work fine.
There was a problem hiding this comment.
Thats reasonable. Then, let's keep it for now.
friedrichwilken
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Thats reasonable. Then, let's keep it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)