Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace action to install yq with some shell commands #68

Merged

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Feb 5, 2024

Description

We cannot utilize GitHub actions that have not been approve by the org. For this reason, this PR replace dcarbone/[email protected] with some shell commands to install yq

Changes proposed in this pull request:

Related issue(s)

kyma-project/eventing-manager#361

@friedrichwilken friedrichwilken requested a review from a team as a code owner February 5, 2024 17:39
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2024
@@ -84,7 +93,7 @@ jobs:
if [ -z "$(git status --porcelain)" ]; then
echo "No changes found. No need to create a PR"
else
echo "Changes found. Creating a PR and waiting for it to be merged."
echo "Changes found. Creating a PR and waiting for it to be merged."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the whitespace, now.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 7, 2024
@kyma-bot kyma-bot merged commit e8d1cd6 into kyma-project:main Feb 7, 2024
5 checks passed
friedrichwilken added a commit to friedrichwilken/eventing-manager that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants