Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get branch-name from github var #69

Merged

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Feb 7, 2024

Description

There was a bug in the workflow that would pass the wrong branch name:
for the branch release-1.0 the input "release-${VERSION}" would generate the name release-1.0.x because the VERSION always has three numbers instead of the two of the branch name. So, this PR changes this use ${{ GITHUB_REF_NAME }} to get the var.

e.g. we are on branch release-1.0; the generated version would be release-1.0.1.
"release-${VERSION}" would lead to the branch name release-1.0.1 instead of release-1.0.

Docs for GITHUB_REF_NAME:

The short ref name of the branch or tag that triggered the workflow run. This value matches the branch or tag name shown on GitHub. For example, feature-branch-1. For pull requests, the format is <pr_number>/merge.

Related issue(s)
issue

@friedrichwilken friedrichwilken requested a review from a team as a code owner February 7, 2024 09:09
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 7, 2024
@kyma-bot kyma-bot merged commit 7113a71 into kyma-project:main Feb 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants