First version on how to bring your custom kube-prometheus-stack #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-thaler
requested review from
mmitoraj,
majakurcius,
NHingerl,
grego952,
clebs,
lilitgh,
rakesh-garimella and
hisarbalik
as code owners
kyma-bot
added
the
size/L
NHingerl
reviewed
Sep 12, 2022
NHingerl
reviewed
Sep 13, 2022
a-thaler
commented
Sep 15, 2022
NHingerl
reviewed
Sep 19, 2022
kyma-bot
added
size/XXL
NHingerl
reviewed
Sep 27, 2022
NHingerl
reviewed
Sep 29, 2022
chrkl
reviewed
Sep 29, 2022
|
Further feedback to incorporate:
|
skhalash
changed the title
|
I created a proper issue and moved the open points there so that we can continue merging the current state and adress the open points afterwards in a dedicated PR. kyma-project/kyma#15914 |
a-thaler
changed the title
a-thaler
added
the
area/monitoring
NHingerl
reviewed
Oct 27, 2022
Co-authored-by: Rakesh Garimella <[email protected]>
NHingerl
reviewed
Nov 2, 2022
monitoring-custom-metrics/README.md
Outdated
| 2. Deploy the service: | ||
| 2. Ensure that your Namespace has Istio sidecar injection enabled. This example assumes that the metrics are exposed in a strict mTLS mode: | ||
|
|
||
| ```` |
There was a problem hiding this comment.
I'm surprised that this is rendered correctly; shouldn't the code block end with a couple of backticks in line 28?
rakesh-garimella
previously approved these changes
Nov 2, 2022
Co-authored-by: Nina Hingerl <[email protected]>
NHingerl
previously approved these changes
Nov 2, 2022
|
/hold |
kyma-bot
added
the
do-not-merge/hold
a-thaler
commented
Nov 2, 2022
NHingerl
removed
the
do-not-merge/hold
NHingerl
approved these changes
Nov 2, 2022
chrkl
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
First version for kyma-project/kyma#15914
More needs to be done to solve the ticket, however the current status provides already a lot of value.
Related issue(s)
kyma-project/kyma#14379
kyma-project/kyma#15914