Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scale to zero example #274

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Fix scale to zero example #274

merged 6 commits into from
Oct 31, 2023

Conversation

kwiatekus
Copy link
Contributor

@kwiatekus kwiatekus commented Oct 26, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • use recommended emitCloudEvent way to send CE from a function
  • fix test command - content type matching the actual content in the curl command
  • fix git reference for the sample functions

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 26, 2023
@kwiatekus kwiatekus marked this pull request as ready for review October 27, 2023 10:11
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2023
@pPrecel pPrecel self-assigned this Oct 30, 2023
pPrecel
pPrecel previously approved these changes Oct 30, 2023
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 30, 2023
grego952
grego952 reviewed Oct 30, 2023
View reviewed changes
scale-to-zero-with-keda/README.md Outdated Show resolved Hide resolved
scale-to-zero-with-keda/README.md Outdated Show resolved Hide resolved
scale-to-zero-with-keda/README.md Outdated Show resolved Hide resolved
scale-to-zero-with-keda/README.md Outdated Show resolved Hide resolved
scale-to-zero-with-keda/README.md Outdated Show resolved Hide resolved
scale-to-zero-with-keda/README.md Outdated Show resolved Hide resolved
@kwiatekus @grego952
Apply suggestions from code review
e87ee81 
Co-authored-by: Grzegorz Karaluch <[email protected]>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 31, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 31, 2023
@kyma-bot kyma-bot merged commit 01bbad4 into kyma-project:main Oct 31, 2023
1 check passed
@qooksgit
Copy link

Okay, this PR has been merged. But still, this does not fix my issue. It is not still working on my side. I have posted its status in the slack thread.
@kwiatekus Can you visit the thread?
https://sap-data-intelligence.slack.com/archives/C0140PCSJ5Q/p1698674450246869?thread_ts=1698211631.843389&cid=C0140PCSJ5Q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 approved these changes

@pPrecel pPrecel pPrecel approved these changes

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@NHingerl NHingerl Awaiting requested review from NHingerl

@IwonaLanger IwonaLanger Awaiting requested review from IwonaLanger

@nataliasitko nataliasitko Awaiting requested review from nataliasitko

@m00g3n m00g3n Awaiting requested review from m00g3n

@dbadura dbadura Awaiting requested review from dbadura

@Cortey Cortey Awaiting requested review from Cortey

@anoipm anoipm Awaiting requested review from anoipm

@MichalKalke MichalKalke Awaiting requested review from MichalKalke

Assignees

@pPrecel pPrecel

@grego952 grego952

Labels
lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kwiatekus @kyma-bot @qooksgit @pPrecel @grego952