This repository was archived by the owner on Jan 17, 2025. It is now read-only.
unified namespace variable naming #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-thaler
requested review from
mmitoraj,
NHingerl,
grego952,
IwonaLanger and
nataliasitko
as code owners
kyma-bot
added
the
size/L
NHingerl
approved these changes
Oct 30, 2023
shorim
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The variable name "KYMA_NS" was giving a wrong intention to some users and they assumed the value should be "kyma-system". The intention is exactly the opposite.
So I renamed the env variable to K8S_NAMESPACE and applied that to all examples
Changes proposed in this pull request:
Related issue(s)