Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove kyma-specifics from the prometheus example #277

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

a-thaler
Copy link
Contributor

@a-thaler a-thaler commented Nov 13, 2023

Description
As the monitoring component got removed (kyma-project/kyma#16306), the prometheus example can get simplified by removing the kyma specifics

Changes proposed in this pull request:

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 13, 2023
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2023
@a-thaler a-thaler marked this pull request as ready for review November 16, 2023 16:12
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2023
prometheus/README.md Outdated Show resolved Hide resolved
prometheus/README.md Outdated Show resolved Hide resolved
prometheus/values.yaml Outdated Show resolved Hide resolved
prometheus/values.yaml Outdated Show resolved Hide resolved
Co-authored-by: Małgorzata Świeca <[email protected]>
@kyma-bot kyma-bot merged commit fc388d2 into kyma-project:main Nov 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants