Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Remove 3 telemetry examples #278

Merged
merged 4 commits into from
Dec 13, 2023
Merged

docs: Remove 3 telemetry examples #278

merged 4 commits into from
Dec 13, 2023

Conversation

NHingerl
Copy link
Contributor

@NHingerl NHingerl commented Dec 5, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • remove the examples that were incorporated in the telemetry repo with PR 586
  • refer to new location in the README files
  • ...

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 5, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 5, 2023
@NHingerl NHingerl mentioned this pull request Dec 5, 2023
Merged
8 tasks
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 5, 2023
@NHingerl NHingerl added area/documentation Issues or PRs related to documentation area/telemetry Issues or PRs related to the telemetry module labels Dec 5, 2023
@a-thaler
Copy link
Contributor

a-thaler commented Dec 6, 2023

We should keep the empty README files having a one-liner with the a link to the new location for some months to make life for people easier

@NHingerl NHingerl self-assigned this Dec 11, 2023
@NHingerl NHingerl marked this pull request as ready for review December 12, 2023 13:56
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2023
mmitoraj
mmitoraj previously approved these changes Dec 12, 2023
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 12, 2023
a-thaler
a-thaler reviewed Dec 12, 2023
View reviewed changes
trace-demo/README.md Outdated Show resolved Hide resolved
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 13, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 13, 2023
@kyma-bot kyma-bot merged commit d74f2ad into kyma-project:main Dec 13, 2023
4 checks passed
@NHingerl NHingerl deleted the remove-telemetry-examples branch December 13, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitoraj mmitoraj mmitoraj approved these changes

@a-thaler a-thaler a-thaler approved these changes

@grego952 grego952 Awaiting requested review from grego952

@IwonaLanger IwonaLanger Awaiting requested review from IwonaLanger

@nataliasitko nataliasitko Awaiting requested review from nataliasitko

Assignees

@a-thaler a-thaler

@mmitoraj mmitoraj

@NHingerl NHingerl

Labels
area/documentation Issues or PRs related to documentation area/telemetry Issues or PRs related to the telemetry module cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NHingerl @kyma-bot @a-thaler @mmitoraj