Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup of outdated examples #279

Merged
merged 4 commits into from
Dec 19, 2023
Merged

cleanup of outdated examples #279

merged 4 commits into from
Dec 19, 2023

Conversation

a-thaler
Copy link
Contributor

Description

Changes proposed in this pull request:

  • metrics-otlp example got replaced by the official metrics feature of the telemetry module
  • tracing example brings no value in its current shape, also it should be located in the telemetry docu if relevant, removing it for now
  • charts and tests folder are outdated. They were introduced for automated tests which never got established

Related issue(s)

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 18, 2023
NHingerl
NHingerl previously approved these changes Dec 18, 2023
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 18, 2023
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 19, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 19, 2023
@kyma-bot kyma-bot merged commit 6a4ea1c into kyma-project:main Dec 19, 2023
4 checks passed
@nataliasitko nataliasitko mentioned this pull request Dec 20, 2023
Merged
@a-thaler a-thaler deleted the cleanup branch November 18, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl approved these changes

@chrkl chrkl chrkl approved these changes

@pbochynski pbochynski pbochynski approved these changes

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@grego952 grego952 Awaiting requested review from grego952

@IwonaLanger IwonaLanger Awaiting requested review from IwonaLanger

@nataliasitko nataliasitko Awaiting requested review from nataliasitko

@PK85 PK85 Awaiting requested review from PK85 PK85 is a code owner

Assignees

@pbochynski pbochynski

@chrkl chrkl

@NHingerl NHingerl

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@a-thaler @pbochynski @chrkl @NHingerl @kyma-bot