Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrades golangci-lint to v4 in IM #144

Merged
merged 6 commits into from
Feb 27, 2024

Conversation

Disper
Copy link
Member

@Disper Disper commented Feb 20, 2024

Description

Changes proposed in this pull request:

  • upgrades golangci-lint to v4
  • ...
  • ...

Related issue(s)
Related PR in Kyma repo kyma-project/kyma#18579

@Disper Disper requested a review from a team as a code owner February 20, 2024 09:28
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2024
@Disper Disper changed the title upgrades golangci-lint to v4 upgrades golangci-lint to v4 in IM Feb 26, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2024
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 27, 2024
@kyma-bot kyma-bot merged commit 9b9e21b into kyma-project:main Feb 27, 2024
7 checks passed
@Disper Disper deleted the test_golangci-lint-v4 branch May 15, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants