generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ExtensionsExtender to generate auditlog extension only if auditlog data exists #562
Merged
kyma-bot
merged 10 commits into
kyma-project:main
from
koala7659:fix-extension-auditlog-for-empty-data
Dec 16, 2024
Merged
Fix ExtensionsExtender to generate auditlog extension only if auditlog data exists #562
kyma-bot
merged 10 commits into
kyma-project:main
from
koala7659:fix-extension-auditlog-for-empty-data
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koala7659
changed the title
Fix ExtensionsExtender to generate auditlog extension only if auditlog data exists
[WIP]Fix ExtensionsExtender to generate auditlog extension only if auditlog data exists
Dec 10, 2024
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Dec 10, 2024
…xtension when provided input auditLogData is empty
kyma-bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Dec 11, 2024
…r when provided auditLog data is empty
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Dec 11, 2024
koala7659
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Dec 11, 2024
koala7659
changed the title
[WIP]Fix ExtensionsExtender to generate auditlog extension only if auditlog data exists
Fix ExtensionsExtender to generate auditlog extension only if auditlog data exists
Dec 11, 2024
akgalwas
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for a bug in Extension Extender for a situation when auditog configuration is not configured for given runtime region.
In such a case for created shoot we do not specify
auditConfig.auditPolicy
fields but we a attempting to add auditlog extension with empty data - so we have invalid and not expected extension for non existing auditLog configuration.As a result generated shoot input is rejected and shoot creation fails with error:
{"level":"error","ts":"2024-12-10T14:43:27Z","msg":"Failed to create new gardener Shoot","runtimeID":"78b263d1-ecec-4373-abf4-d7993481261b","shootName":"c-4c21fef","requestID":28,"error":"admission webhook \"validator.shoot-auditlog-admission.extensions.gardener.cloud\" denied the request: [serviceURL: Required value: serviceURL must not be empty, tenantID: Required value: tenantID must not be empty]",",
Fix for Shoot creation and update when
auditLogData
for given Runtime region is empty.