Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid condition status for errors in GardenerCluster #70

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Fix invalid condition status for errors in GardenerCluster #70

merged 2 commits into from
Nov 20, 2023

Conversation

m00g3n
Copy link
Contributor

@m00g3n m00g3n commented Nov 20, 2023 •
edited
Loading

Description

Fix invalid condition status for errors in GardenerCluster.

Changes proposed in this pull request:

  • fix invalid condition status for errors in GardenerCluster
  • fix context for kubeconfig secret deletion
  • refactor status change persisting

@m00g3n m00g3n requested a review from a team as a code owner November 20, 2023 12:12
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 20, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 20, 2023
@kyma-bot kyma-bot merged commit d79e85b into kyma-project:main Nov 20, 2023
2 checks passed
@Disper
Copy link
Member

Disper commented Nov 22, 2023

Looks fine on DEV

  conditions:
  - lastTransitionTime: "2023-11-22T04:29:23Z"
    message: 'Failed to get kubeconfig. Error: failed to get shoot: shoots.core.gardener.cloud
      "d3d2dd1" not found'
    reason: FailedToGetKubeconfig
    status: "False"
    type: KubeconfigManagement
    ```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Disper Disper Disper approved these changes

Assignees

@Disper Disper

Labels
lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m00g3n @Disper @kyma-bot