wip

kyma-project · Dec 12, 2024 · cd48448 · cd48448
1 parent 4ff73d7
commit cd48448
Showing 1 changed file with 35 additions and 32 deletions.
diff --git a/internal/broker/bind_create_test.go b/internal/broker/bind_create_test.go
@@ -59,7 +59,7 @@ func (p *provider) KubeconfigForRuntimeID(runtimeID string) ([]byte, error) {
 	return []byte{}, nil
 }
 
-func TestCreateBindingEndpoint(t *testing.T) {
+func TestCreateBindingEndpoint_dbInsertionInCaseOfError(t *testing.T) {
 	t.Log("test create binding endpoint")
 
 	// Given
@@ -122,36 +122,6 @@ func TestCreateBindingEndpoint(t *testing.T) {
 		require.NotNil(t, binding.ExpiresAt)
 		require.Empty(t, binding.Kubeconfig)
 	})
-
-	t.Run("should return error when expiration_seconds is greater than maxExpirationSeconds", func(t *testing.T) {
-		// when
-		_, err := bindEndpoint.Bind(context.Background(), instanceID1, "binding-id-001", domain.BindDetails{
-			ServiceID:     "123",
-			PlanID:        fixture.PlanId,
-			RawParameters: json.RawMessage(`{"expirationSeconds": 10}`),
-		}, false)
-		require.Error(t, err)
-
-		// then
-		assert.IsType(t, err, &apiresponses.FailureResponse{}, "Get request returned error of unexpected type")
-		apierr := err.(*apiresponses.FailureResponse)
-		assert.Equal(t, http.StatusBadRequest, apierr.ValidatedStatusCode(nil), "Get request status code not matching")
-	})
-
-	t.Run("should return error when expiration_seconds is less than minExpirationSeconds", func(t *testing.T) {
-		// when
-		_, err := bindEndpoint.Bind(context.Background(), instanceID1, "binding-id-002", domain.BindDetails{
-			ServiceID:     "123",
-			PlanID:        fixture.PlanId,
-			RawParameters: json.RawMessage(`{"expirationSeconds": 100000}`),
-		}, false)
-		require.Error(t, err)
-
-		// then
-		assert.IsType(t, err, &apiresponses.FailureResponse{}, "Get request returned error of unexpected type")
-		apierr := err.(*apiresponses.FailureResponse)
-		assert.Equal(t, http.StatusBadRequest, apierr.ValidatedStatusCode(nil), "Get request status code not matching")
-	})
 }
 
 func TestCreateBindingExceedsAllowedNumberOfNonExpiredBindings(t *testing.T) {
@@ -193,7 +163,7 @@ func TestCreateBindingExceedsAllowedNumberOfNonExpiredBindings(t *testing.T) {
 
 }
 
-func TestCreateBindng(t *testing.T) {
+func TestCreateBindingEndpoint(t *testing.T) {
 	bindEndpoint, _ := prepareBindingEndpoint(t, fixBindingConfig())
 
 	t.Run("should return error when expiration_seconds is less than minExpirationSeconds", func(t *testing.T) {
@@ -234,6 +204,18 @@ func TestCreateBindng(t *testing.T) {
 		assert.NotEmptyf(t, binding.Credentials.(Credentials).Kubeconfig, "kubeconfig is empty")
 	})
 
+	t.Run("should create binding with expiration seconds provided", func(t *testing.T) {
+		binding, err := bindEndpoint.Bind(context.Background(), instanceID1, "binding-id-003", domain.BindDetails{
+			ServiceID:     "123",
+			PlanID:        fixture.PlanId,
+			RawParameters: json.RawMessage(`{"expiration_seconds": 1000}`),
+		}, false)
+
+		// then
+		require.NoError(t, err)
+		assert.NotEmptyf(t, binding.Credentials.(Credentials).Kubeconfig, "kubeconfig is empty")
+	})
+
 	t.Run("should report a conflict", func(t *testing.T) {
 		_, err := bindEndpoint.Bind(context.Background(), instanceID1, "binding-id-004", domain.BindDetails{
 			ServiceID:     "123",
@@ -258,6 +240,27 @@ func TestCreateBindng(t *testing.T) {
 		assert.Equal(t, http.StatusConflict, apierr.ValidatedStatusCode(nil), "Get request status code not matching")
 	})
 
+	t.Run("should not report a conflict if parameters are the same", func(t *testing.T) {
+		_, err := bindEndpoint.Bind(context.Background(), instanceID1, "binding-id-005", domain.BindDetails{
+			ServiceID:     "123",
+			PlanID:        fixture.PlanId,
+			RawParameters: json.RawMessage(`{"expiration_seconds": 1000}`),
+		}, false)
+
+		// then
+		require.NoError(t, err)
+
+		// when
+		_, err = bindEndpoint.Bind(context.Background(), instanceID1, "binding-id-005", domain.BindDetails{
+			ServiceID:     "123",
+			PlanID:        fixture.PlanId,
+			RawParameters: json.RawMessage(`{"expiration_seconds": 1000}`),
+		}, false)
+
+		// then
+		require.NoError(t, err)
+	})
+
 }
 
 func TestCreatedBy(t *testing.T) {