Initial DB Table #1213
Merged
Initial DB Table #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
ralikio
added
kind/enhancement
|
Add one of following labels |
kyma-bot
added
the
size/S
kyma-bot
added
do-not-merge/work-in-progress
internal/storage/postsql/init.go
Outdated
| @@ -20,6 +20,7 @@ const ( | |||
| SubaccountStatesTableName = "subaccount_states" | |||
| CreatedAtField = "created_at" | |||
| InstancesArchivedTableName = "instances_archived" | |||
| BindingssTableName = "bindings" | |||
There was a problem hiding this comment.
Suggested change
| BindingssTableName = "bindings" | |
| BindingsTableName = "bindings" |
internal/storage/postsql/write.go
Outdated
| @@ -21,6 +21,37 @@ type writeSession struct { | |||
| transaction *dbr.Tx | |||
| } | |||
|
|
|||
| func (ws writeSession) DeleteBinding(ID string) dberr.Error { | |||
| _, err := ws.deleteFrom(BindingssTableName). | |||
There was a problem hiding this comment.
Suggested change
| _, err := ws.deleteFrom(BindingssTableName). | |
| _, err := ws.deleteFrom(BindingsTableName). |
internal/storage/postsql/write.go
Outdated
| return dberr.AlreadyExists("binding with id %s already exist for runtime %s", binding.ID, binding.RuntimeID) | ||
| } | ||
| } | ||
| return dberr.Internal("Failed to insert record to Instance table: %s", err) |
There was a problem hiding this comment.
Suggested change
| return dberr.Internal("Failed to insert record to Instance table: %s", err) | |
| return dberr.Internal("Failed to insert record to Binding table: %s", err) |
internal/model.go
Outdated
| ExpireationSeconds int64 | ||
| GenerationMethod string | ||
|
|
||
| Version int |
| CreatedAt: binding.CreatedAt, | ||
| UpdatedAt: binding.UpdatedAt, | ||
| ExpiredAt: binding.ExpiredAt, | ||
| Version: binding.Version, |
There was a problem hiding this comment.
Not present in the DB structure yet.
internal/storage/postsql/read.go
Outdated
| return binding, nil | ||
| } | ||
|
|
||
| func (r readSession) ListBindings(runtimeID string) ([]dbmodel.BindingDTO, error) { |
There was a problem hiding this comment.
Access not by index (yet)
|
consider adding Instance ID |
| return sess.DeleteBinding(instanceID) | ||
| } | ||
|
|
||
| func (s *Binding) List(instanceID string) ([]internal.Binding, error) { |
piotrmiskiewicz
approved these changes
Oct 4, 2024
piotrmiskiewicz
previously approved these changes
Oct 4, 2024
piotrmiskiewicz
previously approved these changes
Oct 4, 2024
piotrmiskiewicz
approved these changes
Oct 4, 2024
piotrmiskiewicz
approved these changes
Oct 4, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#1198 #284