Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binding expiration tests to SKR tests #1261

Merged
merged 67 commits into from
Oct 8, 2024
Merged

Add binding expiration tests to SKR tests #1261

merged 67 commits into from
Oct 8, 2024

Conversation

MarekMichali
Copy link
Contributor

@MarekMichali MarekMichali commented Oct 4, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add test for expiration value over max value
  • Add test for expiration value below min value
  • Improve create binding call to return better errors

Related issue(s)

See #1204

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2024
@MarekMichali MarekMichali marked this pull request as ready for review October 7, 2024 14:19
@MarekMichali MarekMichali requested a review from a team as a code owner October 7, 2024 14:19
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 7, 2024 14:19
@MarekMichali
Copy link
Contributor Author

/kind enhancement

@kyma-bot kyma-bot added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 7, 2024
@MarekMichali MarekMichali mentioned this pull request Oct 4, 2024
Closed
5 tasks
szwedm
szwedm approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-gopher-bot kyma-gopher-bot merged commit 67f1dfd into kyma-project:main Oct 8, 2024
25 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

Assignees

@szwedm szwedm

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarekMichali @szwedm @kyma-bot @kyma-gopher-bot