Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Binding Endpoint #1262

Merged
merged 47 commits into from
Oct 10, 2024
Merged

Get Binding Endpoint #1262

merged 47 commits into from
Oct 10, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Oct 4, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • implementation the GET binding endpoint,
  • added db insert inside of the PUT binding handler,
  • get binding memory storage implementation.

Related issue(s)

#284 #1198

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2024
@ralikio ralikio mentioned this pull request Oct 4, 2024
Closed
6 tasks
@ralikio ralikio changed the title Initial Test and Implementation Get Binding Endpoint Oct 4, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 7, 2024
@ralikio ralikio added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 8, 2024
@kyma-project kyma-project deleted a comment from github-actions bot Oct 8, 2024
@ralikio ralikio marked this pull request as ready for review October 8, 2024 10:03
@ralikio ralikio requested a review from a team as a code owner October 8, 2024 10:03
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 8, 2024 10:03
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 10, 2024
@ralikio ralikio added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 10, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 10, 2024
@ralikio ralikio removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit b75f66b into kyma-project:main Oct 10, 2024
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ralikio @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot