Add request logging for service bindings #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KsaweryZietara
added
the
kind/enhancement
|
Add one of following labels |
kyma-bot
added
the
size/M
KsaweryZietara
force-pushed
the
request-logging
branch
from
e2269ed to
4909ab0
Compare
| "user_agent": req.UserAgent(), | ||
| }).Info("Request details") | ||
|
|
||
| if req.Body != nil { |
There was a problem hiding this comment.
We already logged "Request details" - we can consider logging some message if the body is nil.
It can be inferred, but such explicitly put message would make analysis easier.
jaroslaw-pieszka
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
user_id.Related issue(s)
See also #1203, #284 (comment)