Add SKR test for creating more than 10 bindings #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
|
Add one of following labels |
kyma-bot
added
the
size/S
5 tasks
MarekMichali
force-pushed
the
limit-bindings
branch
from
062312a to
ed4b30e
Compare
|
/kind enhancement |
kyma-bot
added
the
kind/enhancement
|
/kind enhancement |
kyma-bot
added
size/L
kyma-bot
added
size/S
kyma-bot
removed
the
do-not-merge/work-in-progress
MarekMichali
commented
Oct 14, 2024
Comment on lines
166
to
168
| errorOccurred = false; | ||
| count = 0; | ||
| while (!errorOccurred && count < 13) { |
There was a problem hiding this comment.
We don't know how many bindings have been created in the previous test before we start this one.
There was a problem hiding this comment.
Could you add such comment in the code?
|
/hold |
kyma-bot
added
the
do-not-merge/hold
ralikio
reviewed
Oct 14, 2024
| errorOccurred = false; | ||
| count = 0; | ||
| while (!errorOccurred && count < 13) { | ||
| bindingID = Math.random().toString(36).substring(2, 18); |
There was a problem hiding this comment.
Could we replace it with uuid generation?
There was a problem hiding this comment.
No problem, I will replace it also in the existing parts of code.
kyma-bot
added
size/M
ralikio
approved these changes
Oct 14, 2024
|
/unhold |
kyma-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
See #1204