Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Bindings Delete API Implementation #1305

Merged
merged 11 commits into from
Oct 14, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Oct 10, 2024

Description

Changes proposed in this pull request:

  • injecting bindings storage into bind_delete endpoint,
  • added instanceID to the delete storage method to uniquely identify a binding,
  • delete method invocation in API endpoint,
  • happy path test.

Related issue(s)

#284 #1198

@ralikio ralikio requested a review from a team as a code owner October 10, 2024 15:20
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 10, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 10, 2024 15:20
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2024
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@ralikio ralikio added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 10, 2024
@piotrmiskiewicz
Copy link
Member

I think we need at least one small happy path binding deletion test in cmd/broker. It can be a next PR if you like

kyma-project#1305 (comment) - moved test to broker package; switch memory db to the container db.

kyma-project#1305 (comment) - new test case introduction.
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 14, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 14, 2024
@ralikio
Copy link
Member Author

ralikio commented Oct 14, 2024

I think we need at least one small happy path binding deletion test in cmd/broker. It can be a next PR if you like

@piotrmiskiewicz I intended bind_create_test.go to serve that purpose. However, the placement was incorrect. I have moved the file to broker package as well as switched in memory database to the one created in a container.

@kyma-gopher-bot kyma-gopher-bot merged commit fd1ebb1 into kyma-project:main Oct 14, 2024
25 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants