Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Bindings' Resources Removal #1322

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Missing Bindings' Resources Removal #1322

merged 6 commits into from
Oct 15, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Oct 15, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • missed removal of service accounts, cluster roles and cluster role bindings during removal of a binding.

Related issue(s)

#284 #1198

@ralikio ralikio requested a review from a team as a code owner October 15, 2024 11:57
@ralikio ralikio added the kind/bug Categorizes issue or PR as related to a bug. label Oct 15, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 15, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 15, 2024 11:57
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 15, 2024
@kyma-project kyma-project deleted a comment from github-actions bot Oct 15, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 15, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit c681cbf into kyma-project:main Oct 15, 2024
27 checks passed
@ralikio ralikio mentioned this pull request Nov 19, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ralikio @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot