Fix delete request in SKR bindings test #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
MarekMichali
changed the title
|
Add one of following labels |
kyma-bot
added
the
size/XS
|
/kind enhancement |
kyma-bot
added
the
kind/enhancement
MarekMichali
commented
Oct 16, 2024
Comment on lines
294
to
-296
| async deleteBinding(instanceID, bindingID) { | ||
| const endpoint = `service_instances/${instanceID}/service_bindings/${bindingID} | ||
| ?accepts_incomplete=false&service_id=${KYMA_SERVICE_ID}&plan_id=${this.planID}`; |
There was a problem hiding this comment.
This new line split was causing issues.
kyma-bot
removed
the
do-not-merge/work-in-progress
ralikio
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
See #1204