Corrected Binding Insert Order

[ralikio]

Description

Changes proposed in this pull request:

• put insert before K8S resources creation in binding creation process,
• test that rely on nil providers to make sure that before panic occurs the test created a binding,
• updating expires at and a kubeconfig after its generation,
• asserting that expires at is set even when failed occured.

Related issue(s)

#1364

[piotrmiskiewicz]

I don't want to force my idea, just to see another idea:

type provider struct {
}

func (p *provider) K8sClientSetForRuntimeID(runtimeID string) (kubernetes.Interface, error) {
	c := fake.NewSimpleClientset()
	c.PrependReactor("create", "serviceaccounts", func(action k8stesting.Action) (bool, runtime.Object, error) {
		return true, nil, fmt.Errorf("error")
	})
	return c, nil
}

then the test without recover:

_, err = db.Bindings().Get(instanceID1, "binding-id")
	require.Error(t, err)
	require.True(t, dberr.IsNotFound(err))

	// when
	_, _ = bindEndpoint.Bind(context.Background(), instanceID1, "binding-id", domain.BindDetails{
		ServiceID: "123",
		PlanID:    fixture.PlanId,
	}, false)

	// then
	binding, err := db.Bindings().Get(instanceID1, "binding-id")
	require.NoError(t, err)
	require.Equal(t, instanceID1, binding.InstanceID)
	require.Equal(t, "binding-id", binding.ID)

@ralikio edit: simplified in b8e8d1e