Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout of creation Service Binding #1388

Merged
merged 22 commits into from
Oct 31, 2024
Merged

Timeout of creation Service Binding #1388

merged 22 commits into from
Oct 31, 2024

Conversation

ukff
Copy link
Contributor

@ukff ukff commented Oct 25, 2024 •
edited
Loading

Changes proposed in this pull request

  • Add expiration logic to Bind create endpoint. Process will fail if it will now finish in configurable time.

Related issue(s)

#1377

@ukff ukff requested a review from a team as a code owner October 25, 2024 09:33
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 25, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 25, 2024 09:33
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 25, 2024
@ukff ukff changed the title Expire creation of SB Timeout of creation Service Binding Oct 25, 2024
@ralikio ralikio self-requested a review October 25, 2024 14:37
@ukff ukff closed this Oct 28, 2024
auto-merge was automatically disabled October 28, 2024 12:35

Pull request was closed

@ukff ukff reopened this Oct 29, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 29, 2024 14:27
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2024
@ukff ukff added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 30, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit 2b9dbd0 into kyma-project:main Oct 31, 2024
26 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 31, 2024
@ralikio ralikio mentioned this pull request Nov 19, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

@ralikio ralikio Awaiting requested review from ralikio

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ukff @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot