KEB Errors improvements v1 #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add one of following labels |
kyma-bot
added
size/L
Closed
ukff
added
the
kind/enhancement
| @@ -28,7 +30,9 @@ type ApplyKymaStep struct { | |||
| var _ process.Step = &ApplyKymaStep{} | |||
|
|
|||
| func NewApplyKymaStep(os storage.Operations, cli client.Client) *ApplyKymaStep { | |||
| return &ApplyKymaStep{operationManager: process.NewOperationManager(os), k8sClient: cli} | |||
| step := &ApplyKymaStep{k8sClient: cli} | |||
| step.operationManager = process.NewOperationManagerWithMetadata(os, step.Name(), kebErr.KEBDependency) | |||
There was a problem hiding this comment.
it is about Kyma Lifecycle Manager, not KEB
piotrmiskiewicz
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when operation fail, keep it in database
extend option to each step will have depednecy
keep backward compatbility with SRE implementation
Related issue(s)
#1177