Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors -> rename func and extend tests #1496

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Errors -> rename func and extend tests #1496

merged 3 commits into from
Nov 27, 2024

Conversation

ukff
Copy link
Contributor

@ukff ukff commented Nov 27, 2024 •
edited
Loading

Related issue(s)

#1177

@ukff ukff requested a review from a team as a code owner November 27, 2024 14:42
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 27, 2024
@ukff ukff added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed cla: yes Indicates the PR's author has signed the CLA. labels Nov 27, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) November 27, 2024 14:43
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 27, 2024
@ukff ukff changed the title Errors, rename func and extend tests Errors -> rename func and extend tests Nov 27, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 27, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. and removed lgtm Looks good to me! labels Nov 27, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit 62d5a59 into kyma-project:main Nov 27, 2024
26 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 27, 2024
@ukff ukff mentioned this pull request Nov 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ukff @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot