Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEB Parameter to Enforce One Region for a Shoot and a Seed #781

Closed
wants to merge 22 commits into from
Closed

KEB Parameter to Enforce One Region for a Shoot and a Seed #781

wants to merge 22 commits into from

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented May 22, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • parameter shootAndSeedSameRegion sent to provisioner,
  • parameter shootAndSeedSameRegion received from KEB input,
  • schema update.

Related issue(s)

kyma-project/kyma#18182

@ralikio ralikio requested a review from a team as a code owner May 22, 2024 14:26
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label May 22, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 22, 2024
@ralikio ralikio added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 22, 2024
@ralikio ralikio mentioned this pull request May 22, 2024
Open
19 tasks
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2024
jaroslaw-pieszka
jaroslaw-pieszka reviewed Jun 5, 2024
View reviewed changes
internal/process/input/input_test.go

// then
require.NoError(t, err)
assert.NotNil(t, input.ClusterConfig.GardenerConfig.ShootAndSeedSameRegion)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You verify only if parameter is not nil, not if it is true.

jaroslaw-pieszka
jaroslaw-pieszka reviewed Jun 5, 2024
View reviewed changes
internal/provisioner/fake_client.go
@@ -288,6 +288,11 @@ func (c *FakeClient) IsShootUpgraded(runtimeID string) bool {
return found
}

func (c *FakeClient) IsSeedAndRegionValidationEnabled() bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking if ptr is not nil only.
What if pointer points to false?

@ralikio
Copy link
Member Author

ralikio commented Jun 5, 2024

Split into two separate PRs:

@ralikio ralikio closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka left review comments

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralikio @jaroslaw-pieszka @kyma-bot