Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow floats for CPU cloud-spec values #199

Merged
merged 13 commits into from
Feb 20, 2025

Conversation

k15r
Copy link
Collaborator

@k15r k15r commented Feb 18, 2025

Description

Changes proposed in this pull request (what was done and why):

  • allow floats for values in cloud-specs to allow mapping other resource types with finer granularity.

NOTE: this change requires a schema change of edp

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@k15r k15r requested a review from a team as a code owner February 18, 2025 15:06
@github-actions github-actions bot added this to the 1.7.0 milestone Feb 18, 2025
@k15r k15r added area/UsageReporting Changes to reporting of usage metrics to a metering backend do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 18, 2025
@k15r k15r requested a review from a team as a code owner February 19, 2025 07:35
@kyma-bot kyma-bot added size/XXL and removed size/L labels Feb 19, 2025
shorim
shorim previously approved these changes Feb 19, 2025
@kyma-bot kyma-bot added the lgtm label Feb 19, 2025
This reverts commit d318149.
TeodorSAP
TeodorSAP previously approved these changes Feb 20, 2025
@k15r
Copy link
Collaborator Author

k15r commented Feb 20, 2025

events retrieved from edp with all machines configured to report 2.8 cpus

{
  "runtime_id": "6303fea0-19da-4957-8385-574d972e53ae",
  "sub_account_id": "fed03c96-b09a-4d5e-a586-87567912ee08",
  "shoot_name": "c-846aced",
  "timestamp": "2025-02-20T08:21:13Z",
  "compute": {
    "vm_types": [
      {
        "name": "n2-standard-2",
        "count": 7
      }
    ],
    "provisioned_cpus": 19.6,
    "provisioned_ram_gb": 56,
    "provisioned_volumes": {
      "size_gb_total": 72,
      "count": 4,
      "size_gb_rounded": 128
    }
  }
}

@k15r k15r enabled auto-merge February 20, 2025 08:26
@k15r k15r removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2025
@kyma-bot kyma-bot added the lgtm label Feb 20, 2025
@k15r k15r added this pull request to the merge queue Feb 20, 2025
Merged via the queue into kyma-project:main with commit b3bef83 Feb 20, 2025
18 checks passed
@k15r k15r deleted the support-fractional-cpu branch February 20, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UsageReporting Changes to reporting of usage metrics to a metering backend cla: yes kind/feature lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants