Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Webhook Auth by default #18200

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

muralov
Copy link
Contributor

@muralov muralov commented Sep 20, 2023

Enable Webhook Auth feature flag by default. This is required by the eventing-manager as eventing manager is implemented explicitly with eventing webhook auth.

@muralov muralov requested a review from a team as a code owner September 20, 2023 08:52
@muralov muralov requested a review from marcobebway September 20, 2023 08:52
@netlify
Copy link

netlify bot commented Sep 20, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 45d67cd

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 45d67cd
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/650ae76d3873100008eee73f
😎 Deploy Preview https://deploy-preview-18200--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 20, 2023
@muralov muralov requested review from grischperl and removed request for marcobebway September 20, 2023 09:23
@muralov
Copy link
Contributor Author

muralov commented Sep 20, 2023

/retest

@muralov muralov force-pushed the enable-webhook-auth branch from 2d0e2cf to 45d67cd Compare September 20, 2023 12:36
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 21, 2023
@muralov
Copy link
Contributor Author

muralov commented Sep 21, 2023

/retest

@kyma-bot kyma-bot merged commit f27b81d into kyma-project:main Sep 21, 2023
4 checks passed
@muralov muralov deleted the enable-webhook-auth branch September 21, 2023 09:10
@muralov muralov linked an issue Sep 21, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Event Mesh Subscription Creation
3 participants