Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ModuleInfo as optional to ModuleTemplate #1906

Closed
wants to merge 16 commits into from
Closed

feat: Add ModuleInfo as optional to ModuleTemplate #1906

wants to merge 16 commits into from

Conversation

ruanxin
Copy link
Contributor

@ruanxin ruanxin commented Sep 30, 2024

Description

Related issue(s)
#1841

@ruanxin ruanxin requested a review from a team as a code owner September 30, 2024 14:55
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 30, 2024
@ruanxin ruanxin requested a review from a team as a code owner October 1, 2024 14:57
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2024
@ruanxin ruanxin force-pushed the add-info-field-to-mt branch from f3b7474 to ed8cf87 Compare October 1, 2024 15:16
@c-pius c-pius linked an issue Oct 2, 2024 that may be closed by this pull request
[ModuleCatalog] Add .spec.info to ModuleTemplate #1841
Closed
3 tasks
c-pius
c-pius reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@c-pius c-pius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to run the manifests make target to update the CRD.

api/v1beta2/moduletemplate_types.go Outdated Show resolved Hide resolved
api/v1beta2/moduletemplate_types.go Outdated Show resolved Hide resolved
api/v1beta2/moduletemplate_types.go Show resolved Hide resolved
api/v1beta2/moduletemplate_types.go Outdated Show resolved Hide resolved
docs/contributor/resources/03-moduletemplate.md Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 2, 2024
c-pius
c-pius previously approved these changes Oct 2, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 2, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 2, 2024
c-pius
c-pius previously approved these changes Oct 2, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 2, 2024
mmitoraj
mmitoraj previously approved these changes Oct 2, 2024
View reviewed changes
@ruanxin ruanxin dismissed stale reviews from mmitoraj and c-pius via 0cf0829 October 2, 2024 10:40
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 2, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 2, 2024

New changes are detected. LGTM label has been removed.

@ruanxin ruanxin added the lgtm Looks good to me! label Oct 2, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 2, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 2, 2024

New changes are detected. LGTM label has been removed.

@ruanxin ruanxin closed this Oct 2, 2024
@c-pius c-pius removed a link to an issue Oct 7, 2024
[ModuleCatalog] Add .spec.info to ModuleTemplate #1841
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitoraj mmitoraj mmitoraj left review comments

@c-pius c-pius c-pius left review comments

Assignees

@c-pius c-pius

@mmitoraj mmitoraj

Labels
cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruanxin @kyma-bot @c-pius @mmitoraj