Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NATS manager deployment uses generic labels for pod selector #221

Closed
pbochynski opened this issue Nov 15, 2023 · 2 comments · Fixed by #236
Closed

NATS manager deployment uses generic labels for pod selector #221

pbochynski opened this issue Nov 15, 2023 · 2 comments · Fixed by #236
Assignees
@marcobebway
Labels
area/eventing Issues or PRs related to eventing kind/bug Categorizes issue or PR as related to a bug.
Milestone
1.0.3

Comments

@pbochynski
Copy link
Contributor

Description
The nats manager deployment contains only one label in selector:

control-plane: manager

And only that label is set in the pod template. The label is generic and does not identify the pod.

Expected result

Pod selector matches only nats manager pods
@pbochynski
Copy link
Contributor Author

Similar issue to: kyma-project/application-connector-manager#108

@friedrichwilken friedrichwilken added the kind/bug Categorizes issue or PR as related to a bug. label Nov 15, 2023
@k15r k15r mentioned this issue Nov 20, 2023
Closed
3 tasks
@grischperl grischperl self-assigned this Nov 30, 2023
@marcobebway marcobebway mentioned this issue Dec 1, 2023
Merged
@marcobebway marcobebway linked a pull request Dec 1, 2023 that will close this issue
Use common labels for the NATS manager resources #236
Merged
@marcobebway marcobebway added the area/eventing Issues or PRs related to eventing label Dec 1, 2023
@marcobebway
Copy link
Contributor

marcobebway commented Dec 12, 2023 •
edited
Loading

For the time being, we added common labels for the resources managed by the NATS manager.
Updating the selectors will happen in a later ticket which should focus on doing the update without downtime.

@friedrichwilken friedrichwilken added this to the 1.0.3 milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcobebway marcobebway

Labels
area/eventing Issues or PRs related to eventing kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
1.0.3
Development

Successfully merging a pull request may close this issue.

Use common labels for the NATS manager resources marcobebway/nats-manager
4 participants
@pbochynski @marcobebway @friedrichwilken @grischperl