Use common labels for the NATS manager resources #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
size/M
marcobebway
added
kind/bug
marcobebway
commented
Dec 1, 2023
| @@ -226,8 +226,6 @@ func Test_Validate_CreateNATS(t *testing.T) { | |||
| // object in the K8s cluster, then tries to modify it with givenUpdates, and test the error that was caused by this | |||
| // update, against a wantErrMsg. | |||
| func Test_Validate_UpdateNATS(t *testing.T) { | |||
| t.Parallel() | |||
There was a problem hiding this comment.
I had to remove parallelism because it caused flakiness.
|
/hold |
kyma-bot
added
the
do-not-merge/hold
k15r
approved these changes
Dec 4, 2023
|
/hold cancel |
kyma-bot
removed
the
do-not-merge/hold
marcobebway
commented
Dec 5, 2023
Comment on lines
+319
to
+324
| commonLabels: | ||
| app.kubernetes.io/component: nats-manager | ||
| app.kubernetes.io/created-by: nats-manager | ||
| app.kubernetes.io/managed-by: nats-manager | ||
| app.kubernetes.io/part-of: nats-manager | ||
| control-plane: nats-manager |
There was a problem hiding this comment.
I did not apply the following labels:
- app.kubernetes.io/instance: eventing
+ app.kubernetes.io/instance: nats-manager
- app.kubernetes.io/name: nats
+ app.kubernetes.io/name: nats-managerbecause they will case the label selectors to change which we don't want for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use common labels for the NATS manager resources.
Related issue(s)