Block deletion if customer stream and sap stream consumer exists #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't delete if customer stream exists other than sap stream * Don't delete if sap stream consumer exists * Add WARNING state if deletion is blocked * Add and adapt tests for deletion block
kyma-bot
added
the
size/L
5 tasks
k15r
reviewed
Sep 22, 2023
| ConsumerExistsErrorMsg = "Cannot delete NATS cluster as stream consumer exists" | ||
| natsClientPort = 4222 | ||
| InstanceLabelKey = "app.kubernetes.io/instance" | ||
| SapStreamName = "sap" |
There was a problem hiding this comment.
this constant should be sourced from a single location otherwise it will at eventually go out of sync in the various components that use it
k15r
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't delete if sap stream consumer exists or customer streams exist
Description
Related issue(s)
#143