Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nats prefix for UI configmap name #198

Closed
wants to merge 2 commits into from

Conversation

muralov
Copy link
Contributor

@muralov muralov commented Oct 23, 2023

Add nats prefix for UI configmap name

@muralov muralov requested a review from a team as a code owner October 23, 2023 15:01
@muralov muralov requested a review from mfaizanse October 23, 2023 15:01
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2023
@@ -1,5 +1,5 @@
configMapGenerator:
- name: operator.kyma-project.io
- name: nats.operator.kyma-project.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test what will happen to the existing clusters which already have a configMap. There will be duplicate configMaps once this PR is merged and released.

@muralov muralov force-pushed the change-ui-configmapname branch from fc90768 to c1e6be8 Compare December 13, 2023 09:02
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Dec 13, 2023
@muralov muralov closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants