Add cluster size validation rule #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
size/S
kyma-bot
added
size/M
friedrichwilken
requested changes
Nov 21, 2023
api/v1alpha1/nats_types.go
Outdated
| @@ -125,6 +125,7 @@ type Cluster struct { | |||
| // +kubebuilder:default:=3 | |||
| // +kubebuilder:validation:Minimum:=1 | |||
| // +kubebuilder:validation:XValidation:rule="(self%2) != 0", message="size only accepts odd numbers" | |||
| // +kubebuilder:validation:XValidation:rule="!(oldSelf > 1 && self == 1)", message="size cannot be reduced to 1 once it was >1" | |||
There was a problem hiding this comment.
message="size cannot be reduced to 1 once it was >1"
Wasn't this the other way around? Once it will be set to 1 it cannot be changed?
There was a problem hiding this comment.
No, the rule is, once it was set to greater than 1 it can never be 1 again. I can try to make the message clearer like cannot be set to 1 if size was greater than 1?
There was a problem hiding this comment.
Okay, looks I got that wrong. Nevermind then.
| @@ -267,6 +267,36 @@ func Test_Validate_UpdateNATS(t *testing.T) { | |||
| }, | |||
| wantErrMsg: "fileStorage is immutable once it was set", | |||
| }, | |||
| { | |||
| name: `validation of cluster fails, if cluster.size>1 gets set to 1'`, | |||
There was a problem hiding this comment.
This sentence is a little confusing. How about:
Suggested change
| name: `validation of cluster fails, if cluster.size>1 gets set to 1'`, | |
| name: `validation of cluster fails, if cluster.size was set to a value >1 and now gets changed to 1'`, |
...or something similar.
friedrichwilken
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Validation rule:
Related issue(s)
#210