Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NATS URL in the NATS CR status #239

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Add NATS URL in the NATS CR status #239

merged 2 commits into from
Dec 8, 2023

Conversation

marcobebway
Copy link
Contributor

@marcobebway marcobebway commented Dec 5, 2023 •
edited
Loading

Description

Add NATS URL in the NATS CR status.

Related issue(s)

@marcobebway marcobebway self-assigned this Dec 5, 2023
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 5, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 5, 2023
@marcobebway marcobebway linked an issue Dec 5, 2023 that may be closed by this pull request
Add server urls to status sub resource #234
Closed
1 task
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 5, 2023
@marcobebway marcobebway added the area/eventing Issues or PRs related to eventing label Dec 5, 2023
@marcobebway marcobebway force-pushed the 234-add-nats-url-to-cr-status branch from 1e831c6 to ddeec73 Compare December 5, 2023 23:40
@marcobebway
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2023
@marcobebway
Copy link
Contributor Author

TODO: Add more tests

@marcobebway
Copy link
Contributor Author

/test all

@marcobebway
Copy link
Contributor Author

/retest

@marcobebway marcobebway force-pushed the 234-add-nats-url-to-cr-status branch from ddeec73 to 05c404f Compare December 6, 2023 21:19
@marcobebway marcobebway marked this pull request as ready for review December 6, 2023 21:29
@marcobebway marcobebway requested review from a team as code owners December 6, 2023 21:29
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2023
@marcobebway
Copy link
Contributor Author

/test all

@marcobebway
Copy link
Contributor Author

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 7, 2023
@marcobebway
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2023
@marcobebway
Copy link
Contributor Author

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2023
friedrichwilken
friedrichwilken approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@friedrichwilken friedrichwilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot merged commit e4c497b into kyma-project:main Dec 8, 2023
9 checks passed
@marcobebway marcobebway deleted the 234-add-nats-url-to-cr-status branch December 8, 2023 10:35
@friedrichwilken friedrichwilken added this to the 1.0.3 milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl approved these changes

@friedrichwilken friedrichwilken friedrichwilken approved these changes

Assignees

@marcobebway marcobebway

@friedrichwilken friedrichwilken

@NHingerl NHingerl

Labels
area/eventing Issues or PRs related to eventing cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.

Add server urls to status sub resource
4 participants
@marcobebway @kyma-bot @friedrichwilken @NHingerl