Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump linter to v1.55 #258

Merged
merged 7 commits into from
Dec 19, 2023
Merged

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Dec 15, 2023

Description

Changes proposed in this pull request:

  • fix formatting in github workflow
  • bump the version of golangcli-lint to v1.55
  • fix linting issues

Related issue(s)

Replace doublequotes with singlequotes in codequality.yml.
Bump the golangcli-lint version from v1.52 to v1.55 for increased stability. https://github.com/golangci/golangci-lint/releases/tag/v1.55.2
@friedrichwilken friedrichwilken requested a review from a team as a code owner December 15, 2023 09:38
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2023
k15r
k15r previously approved these changes Dec 15, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 15, 2023
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2023
Fix some formating issues and typos in the comments.
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 19, 2023
@kyma-bot kyma-bot merged commit ee97c1a into kyma-project:main Dec 19, 2023
9 checks passed
@friedrichwilken friedrichwilken deleted the bump-linter branch December 20, 2023 07:39
@friedrichwilken friedrichwilken self-assigned this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants