Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the order in which release scripts run #266

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix the order in which release scripts run #266

merged 1 commit into from
Dec 21, 2023

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Dec 20, 2023 •
edited
Loading

Description

At the current version, the create-release workflow does an operation based on a script, which is not available at that point in time. We need to run the checkout first.

Changes proposed in this pull request:

  • run checkout before check_version_format.sh

Related issue(s)

#245

@friedrichwilken friedrichwilken requested a review from a team as a code owner December 20, 2023 14:31
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2023
@friedrichwilken friedrichwilken linked an issue Dec 21, 2023 that may be closed by this pull request
setup new pathways for nats manager to release new modules with semantic version #245
Closed
5 tasks
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 21, 2023
@kyma-bot kyma-bot merged commit 3c5988e into kyma-project:main Dec 21, 2023
9 checks passed
@friedrichwilken friedrichwilken deleted the fix-release-order branch February 21, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grischperl grischperl grischperl approved these changes

Assignees

@grischperl grischperl

Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup new pathways for nats manager to release new modules with semantic version
3 participants
@friedrichwilken @grischperl @kyma-bot