Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement caching rules #272

Merged
merged 16 commits into from
Jan 4, 2024
Merged

Implement caching rules #272

merged 16 commits into from
Jan 4, 2024

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Dec 29, 2023 •
edited
Loading

Description
To prevent high memory consumption nats-manager's internal client will only cache relevant resources.

Changes proposed in this pull request:

  • Cache runtime objects only created by nats-manager via label-selector app.kubernetes.io/managed-by:nats-manager

Related issue(s)

#261

@friedrichwilken friedrichwilken added the tide/merge-blocker Denotes an issue that blocks the tide merge queue for a branch while it is open. label Dec 29, 2023
@friedrichwilken friedrichwilken requested a review from a team as a code owner December 29, 2023 17:33
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 29, 2023
@friedrichwilken friedrichwilken added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 29, 2023
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 29, 2023
@friedrichwilken friedrichwilken removed tide/merge-blocker Denotes an issue that blocks the tide merge queue for a branch while it is open. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 29, 2023
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 29, 2023
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 1, 2024
@friedrichwilken friedrichwilken force-pushed the implement-caching-rules branch from 86e71c0 to 73e5375 Compare January 1, 2024 20:49
@friedrichwilken friedrichwilken linked an issue Jan 1, 2024 that may be closed by this pull request
implement caching rules for nats-manager #261
Closed
2 tasks
@friedrichwilken friedrichwilken requested a review from a team as a code owner January 1, 2024 22:11
@friedrichwilken friedrichwilken force-pushed the implement-caching-rules branch 3 times, most recently from ab5bef0 to b6bbe49 Compare January 3, 2024 14:36
@friedrichwilken friedrichwilken force-pushed the implement-caching-rules branch from b6bbe49 to fda7059 Compare January 3, 2024 14:53
@mfaizanse mfaizanse requested review from mfaizanse and removed request for muralov January 4, 2024 08:19
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 4, 2024
@kyma-bot kyma-bot merged commit 6fd3d93 into kyma-project:main Jan 4, 2024
9 checks passed
@friedrichwilken friedrichwilken deleted the implement-caching-rules branch February 21, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaizanse mfaizanse mfaizanse approved these changes

Assignees

@mfaizanse mfaizanse

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement caching rules for nats-manager
3 participants
@friedrichwilken @mfaizanse @kyma-bot