Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NATS Server to 2.10.7 and helm chart configs #273

Merged
merged 8 commits into from
Jan 19, 2024

Conversation

mfaizanse
Copy link
Member

@mfaizanse mfaizanse commented Jan 2, 2024

Description

Changes proposed in this pull request:

  • Bumped NATS Server to 2.10.7.
  • Bumped NATS config-reloader to 0.14.1.
  • Added resource requests+limits to config-reloader and prometheus exporter containers.
  • Update NATS configMap and statefulSet.
    • Changed server_name: $POD_NAME to server_name: $SERVER_NAME in NATS config.
    • Added SERVER_NAME env to NATS Statefulset.

Related issue(s)

@mfaizanse mfaizanse requested a review from a team as a code owner January 2, 2024 13:55
@mfaizanse mfaizanse requested a review from muralov January 2, 2024 13:55
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Jan 2, 2024
@mfaizanse mfaizanse added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jan 2, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Jan 2, 2024
@mfaizanse mfaizanse linked an issue Jan 3, 2024 that may be closed by this pull request
7 tasks
@mfaizanse mfaizanse mentioned this pull request Jan 8, 2024
7 tasks
// **********************
// TODO: remove this section when NATS server 2.10.x is released.
// `max_file` is changed to `max_file_store` in NATS 2.10.x.
// `max_mem` is changed to `max_memory_store` in NATS 2.10.x.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memory: 32Mi
requests:
cpu: 10m
memory: 20Mi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set these values based on consumption in k8s: #104 (comment)

@mfaizanse mfaizanse removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2024
@mfaizanse mfaizanse requested review from k15r and removed request for muralov January 11, 2024 09:23
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 19, 2024
@kyma-bot kyma-bot merged commit 9d2e28e into kyma-project:main Jan 19, 2024
8 checks passed
@mfaizanse mfaizanse deleted the bumpnats2107 branch January 19, 2024 09:48
@mfaizanse mfaizanse added this to the 1.1.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update NATS Server Version 2.10.7
3 participants