generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set the right image for the release #283
Merged
kyma-bot
merged 2 commits into
kyma-project:main
from
friedrichwilken:fix-wrong-image-in-release
Jan 10, 2024
Merged
set the right image for the release #283
kyma-bot
merged 2 commits into
kyma-project:main
from
friedrichwilken:fix-wrong-image-in-release
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment in case of an release the image gets set to a default value of image: op-skr-registry.localhost:8888/unsigned/manager-images/nats-manager:<version> in the nats-manager.yaml due to an unset IMG var. This commit changes that by setting the IMG. Also, the script was made more generic by removing references to nats and instead, pass the string nats as a var from the ghaw.
kyma-bot
added
area/ci
Issues or PRs related to CI related topics
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Jan 10, 2024
marcobebway
previously approved these changes
Jan 10, 2024
/cla-recheck |
1 similar comment
/cla-recheck |
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
and removed
lgtm
Looks good to me!
labels
Jan 10, 2024
marcobebway
approved these changes
Jan 10, 2024
friedrichwilken
added a commit
to friedrichwilken/nats-manager
that referenced
this pull request
Jan 10, 2024
* set the right image for the release At the moment in case of an release the image gets set to a default value of image: op-skr-registry.localhost:8888/unsigned/manager-images/nats-manager:<version> in the nats-manager.yaml due to an unset IMG var. This commit changes that by setting the IMG. Also, the script was made more generic by removing references to nats and instead, pass the string nats as a var from the ghaw. * fix comment
kyma-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
* set the right image for the release At the moment in case of an release the image gets set to a default value of image: op-skr-registry.localhost:8888/unsigned/manager-images/nats-manager:<version> in the nats-manager.yaml due to an unset IMG var. This commit changes that by setting the IMG. Also, the script was made more generic by removing references to nats and instead, pass the string nats as a var from the ghaw. * fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the release of
1.0.3
on github the image was set to a wrong value:but it should be:
in the
create release
ghaw the manifest gets rendered at this step:in the script
render_and_upload_manifests.sh
the rendering of the manifests happens by calling a make target:The make target will automatically generate the image --if it was not set-- to
op-skr-registry.localhost:8888/unsigned/manager-images/nats-manager
:which is then used to render the manifest:
This PR fixes this by setting the
IMG
to the right value.Description
Changes proposed in this pull request:
image
value when renderingnats-manger.yaml
in a release (Create release
ghaw).Related issue(s)