Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete pull-nats-module-build usage #298

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions hack/get_module_template_from_build_job.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
# "node_id": "SC_kwDOJBeAG123456789",
# "state": "success",
# "description": "Job succeeded.",
# "target_url": "https://status.build.kyma-project.io/view/gs/kyma-prow-logs/pr-logs/pull/kyma-project_nats-manager/81/pull-nats-module-build/123456789",
# "context": "pull-nats-module-build",
# "target_url": "https://status.build.kyma-project.io/view/gs/kyma-prow-logs/post/kyma-project_nats-manager/81/post-nats-module-build/123456789",
# "context": "post-nats-module-build",
# "created_at": "2023-07-18T11:39:23Z",
# "updated_at": "2023-07-18T11:39:23Z"
# }
Expand All @@ -34,13 +34,8 @@ fi
MODULE_TEMPLATE_FILE="${PROJECT_ROOT}/module-template.yaml"

# set links for artifacts of pull requests.
ARTIFACTS_BASE_URL="https://gcsweb.build.kyma-project.io/gcs/kyma-prow-logs/pr-logs/pull/kyma-project_nats-manager"
TEMPLATE_FILE_BASE_URL="${ARTIFACTS_BASE_URL}/${PR_NUMBER}/pull-nats-module-build"
# if PR_NUMBER is not set, then set links for artifacts of main branch.
if [[ -z "${PR_NUMBER}" ]]; then
ARTIFACTS_BASE_URL="https://gcsweb.build.kyma-project.io/gcs/kyma-prow-logs/logs/post-nats-module-build"
TEMPLATE_FILE_BASE_URL="${ARTIFACTS_BASE_URL}"
fi
TEMPLATE_FILE_BASE_URL="https://gcsweb.build.kyma-project.io/gcs/kyma-prow-logs/pr-logs/pull/kyma-project_nats-manager"
TEMPLATE_FILE_BASE_URL="https://gcsweb.build.kyma-project.io/gcs/kyma-prow-logs/logs/post-nats-module-build"

## Extract the prow job ID.
echo "Extracting prow job Id from: ${COMMIT_STATUS_JSON}"
Expand Down
1 change: 0 additions & 1 deletion testutils/integration/integration.go
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,6 @@ func StartEnvTest(projectRootDir string, celValidationEnabled bool) (*envtest.En
testEnv := &envtest.Environment{
CRDDirectoryPaths: []string{
filepath.Join(projectRootDir, "config", "crd", "bases"),
filepath.Join(projectRootDir, "config", "crd", "external"),
},
ErrorIfCRDPathMissing: true,
AttachControlPlaneOutput: attachControlPlaneOutput,
Expand Down
Loading